Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

TTO-153 Logged-in user doesn't see collections despite matching username #30

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

moseshll
Copy link
Contributor

  • Utils::Get_Remote_User_Names modified to include case-preserved REMOTE_USER and eppn components.
  • Additional tests for logged-in and not-logged-in cases added. (Existing tests are in t/get_remote_user.t)

- `Utils::Get_Remote_User_Names` modified to include case-preserved `REMOTE_USER` and `eppn` components.
@moseshll moseshll requested a review from aelkiss November 27, 2023 22:04
Copy link
Member

@aelkiss aelkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; tests make it clear what the behavior is. Ultimately I hope we can clean some of this up via implementing user profiles and reconsidering this logic there.

sub Get_Remote_User_Names {
my @usernames = ( Get_Remote_User() );
if ( exists $ENV{REMOTE_USER} && defined $ENV{REMOTE_USER} && $ENV{REMOTE_USER} ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, line 110 gets the lowercased REMOTE_USER, and this line gets a case-preserved version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right.

@moseshll moseshll merged commit 67faf66 into master Nov 29, 2023
1 check passed
@moseshll moseshll deleted the TTO-153_mb_username_case_issue branch November 29, 2023 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants