Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ios): update all NSLog to include [PushPlugin] prefix #290

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

erisu
Copy link

@erisu erisu commented Sep 17, 2024

Description

Prefix all NSLog messages with [PushPlugin]

Related Issue

Motivation and Context

To make it clear to an end which is our NSLog messages vs NSLog message that might be printed by other plugins.

How Has This Been Tested?

Build and simulator run test

Screenshots (if appropriate):

Types of changes

  • Refactor/Chore (non-breaking change, non-functionality change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu merged commit 21d49a3 into master Sep 17, 2024
7 checks passed
@erisu erisu deleted the chore/improve-logging branch September 17, 2024 12:07
@erisu erisu added this to the 5.0.0 milestone Nov 13, 2024
@erisu erisu added the ios Related to the iOS platform label Nov 13, 2024
Copy link

github-actions bot commented Dec 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ios Related to the iOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant