Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios)!: migrate to CDVAppDelegate and move logic to PushPlugin.m #300

Merged
merged 12 commits into from
Nov 17, 2024

Conversation

erisu
Copy link

@erisu erisu commented Nov 12, 2024

Description

  • Start using CDVAppDelegate instead of AppDelegate
  • Move logic to PushPlugin.m.

Related Issue

Resolves #252
Resolves #172
Closes #186

Motivation and Context

  • Follow Cordova standards
  • Centralize plugin login

How Has This Been Tested?

  • Tested APNS Payload drops

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu force-pushed the feat/use-cdvappdelegate branch from 98a98e0 to d36ba48 Compare November 13, 2024 07:28
@erisu erisu added this to the 5.0.0 milestone Nov 13, 2024
@erisu erisu added the ios Related to the iOS platform label Nov 13, 2024
@erisu erisu merged commit f82e9f4 into master Nov 17, 2024
7 checks passed
@erisu erisu deleted the feat/use-cdvappdelegate branch November 17, 2024 03:15
Copy link

github-actions bot commented Dec 9, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ios Related to the iOS platform
Projects
None yet
1 participant