fix(android): prevent permission dialog appearing when already denied

[erisu]

Motivation and Context

Prevent second permission dialog from appearing on second launch if user already selected "Don't allow".

Description

If the user selects "Don't allow" for the push notification permission, it is expected that the notification dialog will not reappear on subsequent launches asking the same question.

It is assumed that the user's decision reflects their intent.

If they made a mistake, they can go to the app settings to manually enable the permission.

Additionally, the unusual behavior of the permission dialog reappearing occurs only on the second launch; on the third or later launches, the dialog does not appear.

The changes in this PR ensure that the decision made by the app user is acknowledged and the permission will not be requested again.

This behavior was achieved by adding a call to shouldShowRequestPermissionRationale before invoking the requestPermissions method, which aligns with the guidance provided in the Android documentation.

Reference: Android Documentation - requestPermissions

Related Issue

n/a

How Has This Been Tested?

• Built Android app
• Ran app
• Click "Don't allow" for the notification permission
• Close app
• Open app
• Confirmed that the dialog does not display again.

Additional Test:

• Go to app settings
• Enable notification permission
• Re-open app
• Confirm registration completed

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[maxs15]

@erisu I'm receiving the compilation error "PushPlugin.kt:616:13 Unresolved reference: ActivityCompat" since this commit has been merged.

It looks like the import of "androidx.core.app.ActivityCompat" is missing?

[erisu]

@maxs15 Thank you for catching this.

Everything was working when tested but I guess I forgot to copy over the import line for the PR.

I created a fix #331.
I will merge and release 5.0.2 in a couple of minutes.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.