Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused implicit attribute _cc_toolchains. #372

Closed
wants to merge 3 commits into from
Closed

Remove the unused implicit attribute _cc_toolchains. #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15305e2
Remove the unused implicit attribute `_cc_toolchains`.
mikesinouye Dec 12, 2024
ca982d3
Try bumping bazel version to see what breaks.
mikesinouye Dec 13, 2024
a16c55c
Update to latest available bazel version.
mikesinouye Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ steps:
path: /root/.ssh

# Run the build
- name: gcr.io/cloud-builders/bazel:6.4.0
- name: gcr.io/cloud-builders/bazel:7.3.2
entrypoint: 'bash'
args:
- '-c'
Expand Down
4 changes: 0 additions & 4 deletions verilator/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,6 @@ verilator_cc_library = rule(
doc = "Additional command line options to pass to Verilator",
default = ["-Wall"],
),
"_cc_toolchain": attr.label(
doc = "CC compiler.",
default = Label("@bazel_tools//tools/cpp:current_cc_toolchain"),
),
"_copy_tree": attr.label(
doc = "A tool for copying a tree of files",
cfg = "exec",
Expand Down