Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden DisableDPadAsAnalogInput option #604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Refragg
Copy link

@Refragg Refragg commented Mar 2, 2025

This PR adds a configuration entry in the 'Codes' section named DPadAsAnalogInput allowing someone to enable or disable the movement of Sonic / the world map cursor using the directional pad buttons.
This default behavior on the original game was to not move Sonic / the world map cursor when the dpad was used, I thought it would be good to let people choose this if they want. Let me know if anything else needs to be changed.

@DeaTh-G
Copy link
Contributor

DeaTh-G commented Mar 2, 2025

The d-pad controls are added into the recompilation as an enhancement and are purposefully not exposed on a toggle.

@DeaTh-G DeaTh-G closed this Mar 2, 2025
@DeaTh-G DeaTh-G reopened this Mar 2, 2025
@Refragg
Copy link
Author

Refragg commented Mar 2, 2025

I understand, maybe this option could still exist while staying on by default? I know that it personally does bother me a bunch, it can be annoying for some tricks in the game.

@blueskythlikesclouds
Copy link
Member

What tricks can it be problematic with? Does it get in the way of some pausing tricks or similar?

@Refragg
Copy link
Author

Refragg commented Mar 2, 2025

It's probably not things that a casual player would run into but for example with speedrunning, there is one notorious trick named XP glitch where the dpad and the left stick are used at the same time and it does not really play nicely.

@blueskythlikesclouds
Copy link
Member

Oh okay, that's valid.

@Refragg Refragg force-pushed the dpad-as-analog-input-option branch from 1763117 to 93a1db3 Compare March 2, 2025 18:03
@Refragg
Copy link
Author

Refragg commented Mar 2, 2025

Okay, I've inverted the option so that the dpad movement is enabled by default and I changed it's name to DisableDPadAsAnalogInput instead.

@Refragg Refragg force-pushed the dpad-as-analog-input-option branch from 93a1db3 to c454c83 Compare March 2, 2025 20:19
@Refragg Refragg deployed to external March 2, 2025 20:19 — with GitHub Actions Active
@Refragg Refragg changed the title Add hidden DPadAsAnalogInput option Add hidden DisableDPadAsAnalogInput option Mar 2, 2025
Copy link
Member

@blueskythlikesclouds blueskythlikesclouds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few issues:

  • Space hurrier hooks aren't checking for the bool.
  • IsDPadThreshold isn't checking for the bool, causing the DS4/DualSense touchpad to stop if you press the D-Pad keys despite them not moving the cursor.

@Refragg
Copy link
Author

Refragg commented Mar 3, 2025

Right, I didn't touch these as I wasn't sure what they were doing. Also, I don't have access to a DS4 controller so I won't be able to test this. Either way, I'll get to this later today.

This commit adds a configuration entry in the 'Codes' section named DisableDPadAsAnalogInput allowing someone to enable or disable the movement of Sonic / the world map cursor using the directional pad buttons.
@Refragg Refragg force-pushed the dpad-as-analog-input-option branch from c454c83 to 23900ca Compare March 3, 2025 16:42
@Refragg
Copy link
Author

Refragg commented Mar 3, 2025

Alright, again, I can't test these changes as I don't have a DS4 and I don't know what SpaceHurrier is but i think that's what you wanted me to add, right?

@hyperbx
Copy link
Member

hyperbx commented Mar 3, 2025

PostureSpaceHurrierDPadSupport is for the Gaia Colossus posture.

@Refragg
Copy link
Author

Refragg commented Mar 3, 2025

Ah alright, that makes more sense now, thanks for that information.

@Refragg
Copy link
Author

Refragg commented Mar 3, 2025

Interestingly, from my testing, it looks like those space hurrier hooks might not even be needed. If I remove their entire code, when the dpad analog input is enabled, Gaia Colossus still moves. He doesn't move when the analog input is disabled regardless of whether the original hook code runs or not. Unless the space hurrier posture doesn't actually mean the movement of Gaia Colossus?

@hyperbx
Copy link
Member

hyperbx commented Mar 3, 2025

They're needed for the leaning animations.

@Refragg
Copy link
Author

Refragg commented Mar 3, 2025

Fair enough, I didn't quite understand it i suppose, apologies for my lack of knowledge on all this 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants