Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for More Languages in Installer Wizard #675

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renanjeron
Copy link

DrawLanguagePicker from installer wizard is using a fixed value (6) to list languages to the selection screen.

If a new Language is added, it wont be shown on the selection screen, and if the value is increased to 7, the new language will overflow the last one on the list due to the 3x2 grid.

image

This change the use of a fixed value to a count from the Enum so this problem wont happen if more languages are added by the community.

image

@DeaTh-G
Copy link
Contributor

DeaTh-G commented Mar 3, 2025

The decision to display a fixed amount of languages was made because Unleashed Recompiled only supports languages supported by the original release of the game.

@renanjeron
Copy link
Author

renanjeron commented Mar 3, 2025

The decision to display a fixed amount of languages was made because Unleashed Recompiled only supports languages supported by the original release of the game.

Of course i understand why it was made like that, but that's for now, at least.

Changing to a dynamic grid will make easier later for community projects, including mine.

@DeaTh-G
Copy link
Contributor

DeaTh-G commented Mar 3, 2025

And that's perfectly reasonable for community projects however we are unlikely to support adding more languages in official versions of the Recompilation as that would require all of the original game to get translated too. These language selections affect everything from the Installer Wizard, Options Menu, Achievements and the original game's menus, subtitles, NPC dialogues, Professor Pickle's Hints, Chip's Hints and much much more. As it is I think its better to keep this on forks until the modding of custom menus added by the recompilation becomes possible to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants