Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form mounting when completed #10

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Conversation

rockwellll
Copy link
Collaborator

This PR adjusts the default behavior for mounting forms in a backward compatible way. To not always show the form when it's completed to the user. Forms only mount themselves if they have not yet been completed.

In addition, it's possible to forcefully mount the form regardless if it's been completed or not through passing an object and setting ifCompleted to false, like the following,

async mount({ ifCompleted = true } = {}) {
if(ifCompleted && this.hasBeenCompleted) {
return
}

@rockwellll rockwellll merged commit a17d8e6 into main Jul 5, 2024
2 checks passed
@rockwellll rockwellll deleted the form-mounting-when-completed branch July 6, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant