Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reviewer_comments_count #10

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: reviewer_comments_count #10

merged 1 commit into from
Nov 20, 2024

Conversation

hirokisan
Copy link
Owner

before

gh-lens prs --repo MystenLabs/sui --start-date 2024-11-12 --end-date 2024-11-12 | jq .
...
    {
      "url": "https://github.com/MystenLabs/sui/pull/20244",
      "author": "hayes-mysten",
      "comments_count": 1,
      "reviewee_comments_count": 0,
      "reviewer_comments_count": 2,
      "commits_count": 2,
      "changed_files_count": 4,
      "created_at": "2024-11-12T23:34:54Z",
      "first_contacted_at": "2024-11-12T23:34:58Z",
      "approved_at": "2024-11-13T17:52:40Z",
      "merged_at": "2024-11-13T18:00:17Z"
    },
...

after

gh-lens prs --repo MystenLabs/sui --start-date 2024-11-12 --end-date 2024-11-12 | jq .
...
    {
      "url": "https://github.com/MystenLabs/sui/pull/20244",
      "author": "hayes-mysten",
      "comments_count": 1,
      "reviewee_comments_count": 0,
      "reviewer_comments_count": 1,
      "commits_count": 2,
      "changed_files_count": 4,
      "created_at": "2024-11-12T23:34:54Z",
      "first_contacted_at": "2024-11-12T23:34:58Z",
      "approved_at": "2024-11-13T17:52:40Z",
      "merged_at": "2024-11-13T18:00:17Z"
    },
...

hirokisan
hirokisan commented Nov 20, 2024
View reviewed changes
src/github/client.rs
Comment on lines +332 to +337
if item.state
== pull_requests_query::PullRequestReviewState::APPROVED
&& item.body.is_empty()
{
return false;
}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Exclude cases with no comments in approve

@hirokisan hirokisan marked this pull request as ready for review November 20, 2024 12:53
@hirokisan hirokisan merged commit 29d3716 into main Nov 20, 2024
2 checks passed
@hirokisan hirokisan deleted the fix-reviewer-comments-count branch November 20, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hirokisan