Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi hjc4869,
I more or less now maintain the hip backed of llamacpp now. After some discussion with Johannes Gaessler we have now come to the point that it is likely that i will be allowed to merge this into upstream llamacpp. Since you have been rebaseing this regularly i find it correct to let you do the honors.
I must request some changes:
Please then open a pr with this against llamacpp and request myself and Johannes reviewers.