Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for upstreaming #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Time for upstreaming #1

wants to merge 1 commit into from

Conversation

IMbackK
Copy link

@IMbackK IMbackK commented Feb 5, 2025

Hi hjc4869,

I more or less now maintain the hip backed of llamacpp now. After some discussion with Johannes Gaessler we have now come to the point that it is likely that i will be allowed to merge this into upstream llamacpp. Since you have been rebaseing this regularly i find it correct to let you do the honors.

I must request some changes:

  1. Update your patch to add an option GGML_HIP_ROCWMMA_FATTN here which is off by default
    • ifdef away the rocwmma flash attn path when this is not set, including the include of rocwmma
  2. When GGML_HIP_ROCWMMA_FATTN is on, use cmake's CHECK_INCLUDE_FILE to check for the rocwmma header and abort if its not found.

Please then open a pr with this against llamacpp and request myself and Johannes reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant