Update PHP version to 7.1 minimum. #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shulard
changed the title
Hywan
requested changes
Feb 6, 2018
| @@ -1,5 +1,6 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
You should re-run hoa devtools:cs.
Source/Dispatcher.php
Outdated
| @@ -46,7 +47,6 @@ | |||
| * | |||
| * Abstract dispatcher. | |||
| * | |||
| * @copyright Copyright © 2007-2017 Hoa community | |||
| * @license New BSD License | |||
There was a problem hiding this comment.
You can also remove the @license block.
There was a problem hiding this comment.
I've dropped the @license bloc from all the files.
Source/Dispatcher.php
Outdated
| * @param array $rule Rule. | ||
| * @param \Hoa\Router $router Router. | ||
| * @param \Hoa\View\Viewable $view View. | ||
| * @return mixed | ||
| * @throws \Hoa\Dispatcher\Exception |
There was a problem hiding this comment.
Remove all PHPDoc for methods, methods, and constants. We will use Kitab.
There was a problem hiding this comment.
I've dropped remaining PHP Doc from all the files.
composer.json
Outdated
| @@ -46,5 +47,6 @@ | |||
| "branch-alias": { | |||
| "dev-master": "1.x-dev" | |||
| } | |||
| } | |||
| }, | |||
| "minimum-stability": "dev" | |||
There was a problem hiding this comment.
I wonder if it is required. Thoughts?
There was a problem hiding this comment.
It's required only to be able to install the dev-master dependencies. On the others PR, I haven't commited that change but updated the file locally.
I've dropped this line from the file.
shulard
force-pushed
the
feature/php7
branch
2 times, most recently
from
5808801 to
bd5a791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've worked on upgrading that library to PHP7.1 minimum version. I've splitted the commits for better usability. The version is upgraded in
composer.json, theSourcefolder is created and the code use the new 7.1 syntax.All the tests pass with the actual dependencies. Then I've added a last commit which move dependencies to
dev-master. Actually, thecomposer updatefail because of invalid references. I don't know if we need to add this last commit in this PR...This is related to RFC: hoaproject/Central#75.