fix: Ensure consistent results when retrieving list of devices and sensors concurrently #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsors concurrently * `G90.get_sensors()` and `G90.get_devices()` methods now use locks to ensure consistent results when called concurrently. This change is necessary to prevent duplicated entries in the resulting list or redundant exchanges with the panel when the methods are called concurrently. * `tox`: Skip using `cat` to show `pylint` report to the standard output - recent versions of the tool support such output natively
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
G90.get_sensors()andG90.get_devices()methods now use locks to ensure consistent results when called concurrently. This change is necessary to prevent duplicated entries in the resulting list or redundant exchanges with the panel when the methods are called concurrently.tox: Skip usingcatto showpylintreport to the standard output - recent versions of the tool support such output natively