feat: Add callbacks for tamper and door open when arming #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `G90DeviceNotifications` class now handles door open when arming (via `on_door_open_when_arming` method) and tamper (via additional argument to `on_alarm` method) notifications * `G90Sensor` class now has `tamper_callback` and `door_open_when_arming_callback` properties for callbacks, which are invoked when the sensor reports the corresponding conditions. Additionally `is_tampered` and `is_door_open_when_arming` properties are added to the class to indicate those conditions on the sensor - the conditionas are reset when the panel is armed/disarmed * `G90Alarm` class now has `tamper_callback` and `door_open_when_arming_callback` properties for callbacks similar to sensor ones above, but global on_sensor_activity
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
G90DeviceNotificationsclass now handles door open when arming (viaon_door_open_when_armingmethod) and tamper (via additional argument toon_alarmmethod) notificationsG90Sensorclass now hastamper_callbackanddoor_open_when_arming_callbackproperties for callbacks, which are invoked when the sensor reports the corresponding conditions. Additionallyis_tamperedandis_door_open_when_armingproperties are added to the class to indicate those conditions on the sensor - the conditionas are reset when the panel is armed/disarmedG90Alarmclass now hastamper_callbackanddoor_open_when_arming_callbackproperties for callbacks similar to sensor ones above, but global on_sensor_activity