Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: Independent scrolling behavior for the job list section and the job config aside elements(#762) #771

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

R-Sourabh
Copy link
Contributor

Related Issues

#762

Short Description and Why It's Useful

  • The main element's top margin is removed, its height is set to 100%, and vertical overflow is hidden. Because of this, the main element now takes up the full height of the page.
  • The section and aside elements are allowed to scroll independently, their scrollbars are hidden, and padding is added to their top.
  • Since scrolling is now moved to the section, a scroll event and the enableScrolling function have been added to it. These help toggle the isScrollingEnabled flag to control whether infinite scrolling can be triggered.
  • Additionally, the class ion-content-scroll-host has been added to the section to let ion-infinite-scroll recognize the scrolling element.
  • Also updated the space variable for the job cards' margin-block.

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

Copy link
Contributor

@dt2patel dt2patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ymaheshwari1 ymaheshwari1 merged commit 7685915 into hotwax:main Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants