Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animated Path Configuration property #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leonvogt
Copy link
Contributor

@leonvogt leonvogt commented Mar 2, 2025

This PR would add the ability to add an animated property to the path configuration, which would allow to disable the default animation when navigating to a path.
It's an effort to add more feature parity with iOS.

@leonvogt
Copy link
Contributor Author

leonvogt commented Mar 2, 2025

While working on it, I noticed that the pop animation is still present when navigating back from a path with animated: false.
I was about to change that, but saw that the iOS implementation behaves the same way.

I guess there is an argument for only disabling the push animation and not the pop animation.
But at the same time I think it would be beneficial to have the option to disable both animations.
Depending on the screen, the Android pop animation can be a bit jarring.
Do you have any thoughts on this?

Edit:
While updating the documentation for this change, I've noticed that the explanation for animated also includes "popping":

[...] Specifies whether the navigation should be animated when pushing, popping, or presenting.

Is it possible that the pop animation should not be present with animated: false and it just got lost at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant