Separate Hotwire.config.userAgent from Hotwire.config.userAgentWithWebViewDefault
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thWebViewDefault, so either can be used by an application, depending on the need
jpsphaxer
reviewed
Jan 28, 2025
| */ | ||
| fun userAgent(context: Context): String { | ||
| val userAgent: String get() { |
There was a problem hiding this comment.
just for parity with iOS - should we rename this property as userAgentComponent ?
There was a problem hiding this comment.
@jpsphaxer We've decided to use userAgent instead of userAgentComponent. I've updated the iOS PR accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps align the API available in the iOS library here: hotwired/hotwire-native-ios#75
There are now two readable strings that applications can use:
Hotwire.config.userAgentHotwire.config.userAgentWithWebViewDefault(context)Since the
WebView's default user agent string API is different (and accessible) on Android, it is also provided for an application to read/use.