Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SDK 35 #95

Merged
merged 17 commits into from
Feb 22, 2025
Merged

Add support for SDK 35 #95

merged 17 commits into from
Feb 22, 2025

Conversation

mbarta
Copy link
Contributor

@mbarta mbarta commented Feb 12, 2025

This PR updates the library and the demo app to support SDK 35 and adds the related changes to its code.

Most notably it's the Edge-to-edge support and related insets handling. Additionally, the HotwireWindowThemeObserver has been removed as it was using a deprecated API for handling system bars colours when a custom theme is applied to a Fragment's root view. Instead, we're now using edge-to-edge APIs to show the destination's view behind system bars which achieves the same effect with less custom code.

@mbarta mbarta self-assigned this Feb 12, 2025
@joemasilotti
Copy link
Member

joemasilotti commented Feb 13, 2025

Love this, nice work @mbarta! I'm not going to approve because I'd like a better Android developer than me to give it a review. But I love the API.

jayohms and others added 2 commits February 20, 2025 12:08
@jayohms jayohms merged commit dc6ec2f into main Feb 22, 2025
1 check passed
@jayohms jayohms deleted the mb/sdk35 branch February 22, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants