-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SDK 35 #95
Merged
+124
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Love this, nice work @mbarta! I'm not going to approve because I'd like a better Android developer than me to give it a review. But I love the API. |
…nderneath the system gesture bar
…cting content underneath the sheet when settling
Edge full edge-to-edge Activity view without system bar insets
jayohms
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the library and the demo app to support SDK 35 and adds the related changes to its code.
Most notably it's the Edge-to-edge support and related insets handling. Additionally, the
HotwireWindowThemeObserver
has been removed as it was using a deprecated API for handling system bars colours when a custom theme is applied to a Fragment's root view. Instead, we're now using edge-to-edge APIs to show the destination's view behind system bars which achieves the same effect with less custom code.