Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix to provide parent uuid for kaggle2 #3672

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

tkakar
Copy link
Collaborator

@tkakar tkakar commented Jan 23, 2025

Summary

This PR fixes the logic to provide the parent uuid for kaggle-2 dataset using the vitessce-hints, as they are not support datasets.

Design Documentation/Original Tickets

CAT-1091

Testing

The visualization for kaggle-2 does appear now (http://localhost:5001/browse/dataset/534a590d7336aa99c7fc7afd41e995fc)
All other visualizations (listed on portal-deployment page) are tested and work fine.

Screenshots/Video

Screenshot 2025-01-23 at 9 05 48 AM

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Additional Notes

Please specify any additional information or context relevant to this PR.

@tkakar tkakar requested a review from NickAkhmetov January 23, 2025 14:06
@tkakar
Copy link
Collaborator Author

tkakar commented Jan 23, 2025

@NickAkhmetov for the kaggle-1 segmentation mask I get this error after it loads
Screenshot 2025-01-23 at 9 09 12 AM
This is happening only with the correct segmentation-mask dataset, the others are unscaled and don't show the error.

@tkakar
Copy link
Collaborator Author

tkakar commented Jan 23, 2025

@NickAkhmetov the above issue was resolved with updating vitessce package (second commit)

Copy link
Collaborator

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻 Good work!

@tkakar tkakar merged commit c6409ce into main Jan 23, 2025
8 checks passed
@tkakar tkakar deleted the cat-1091-kaggle2-logic-fix branch January 23, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants