NickAkhmetov/CAT-1010 Integrate Cellpop into organ page #3674
Conversation
| filter: { | ||
| bool: { | ||
| must: [ | ||
| { | ||
| term: { | ||
| 'entity_type.keyword': 'Dataset', | ||
| }, | ||
| }, | ||
| mustHaveOrganClause(searchItems), | ||
| ], | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I believe it's less expensive to perform a filter/query outside of the aggregations. Looking for supporting documentation.
There was a problem hiding this comment.
I can definitely revise this as needed; with that said, this is a direct port of the existing query logic.
| // TODO: This is a placeholder for the actual implementation. | ||
| // We do not currently have a programmatic way to tell | ||
| // whether a dataset actually has labels yet. | ||
| export const DATASETS_WITH_LABELS = [ |
There was a problem hiding this comment.
These are specific datasets within different dataset types, right? There are no underlying patterns?
There was a problem hiding this comment.
These are all of the publicly accessible datasets with complete Azimuth annotations. They are all rna-seq and either kidney or heart; there are also unannotated datasets that fall into those categories, however.
There was a problem hiding this comment.
Could we include that information in the comment?
Summary
This PR adds cellpop visualizations to the organ page. This is best observed on the kidney page.
Current limitations
Remaining todos
Design Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-1010
Testing
Manually tested on:
Screenshots/Video
Kidney page
Heart Page
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.Additional Notes
Other minor changes in this PR: