Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nickakhmetov/cat-1116-cat-1117-cellpop-fixes #3675

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

NickAkhmetov
Copy link
Collaborator

@NickAkhmetov NickAkhmetov commented Jan 30, 2025

Summary

This PR fixes a few issues identified during QA testing of the cellpop component.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-1116
https://hms-dbmi.atlassian.net/browse/CAT-1117

Testing

Visual testing.

Screenshots/Video

Fixes to observe:

  • Violins no longer overlap with each other
  • Extra padding in the control app bar
  • Correct title in table of contents
    image

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Additional Notes

Please specify any additional information or context relevant to this PR.

Copy link
Collaborator

@john-conroy john-conroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@NickAkhmetov NickAkhmetov merged commit fea9c97 into main Jan 30, 2025
8 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/cat-1116-cat-1117-cellpop-fixes branch January 30, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants