Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Austenem/CAT-1180 Restrict lists to HuBMAP users #3698

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

austenem
Copy link
Collaborator

Summary

Restricts "My Lists" feature from all logged-in users to HuBMAP users in accordance with current restrictions on UKV API authentication.

Design Documentation/Original Tickets

CAT-1180 Jira ticket

Copy link
Collaborator

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@austenem
Copy link
Collaborator Author

I think we'll need to apply this to the "Save Entities" button as well:

https://github.com/hubmapconsortium/portal-ui/blob/main/context/app/static/js/components/savedLists/SaveEntitiesButton/SaveEntitiesButton.tsx#L47

Whoops yeah - good call, I forgot that several of the other entry points for My Lists use that boolean as well. Went through and switched the rest of them over 😅

Copy link
Collaborator

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@austenem austenem merged commit 73dbd0a into main Feb 24, 2025
8 checks passed
@austenem austenem deleted the austenem/cat-1180-restrict-lists-to-hubmap branch February 24, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants