Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for DeepSpeed's boolean zero_optimization configuration #3272

Closed

Conversation

ZhangShuaiyi
Copy link

@ZhangShuaiyi ZhangShuaiyi commented Dec 4, 2024

What does this PR do?

DeepSpeed‘s Getting Started guide indicates that zero_optimization can be a boolean value.

{
  "train_batch_size": 8,
  "gradient_accumulation_steps": 1,
  "optimizer": {
    "type": "Adam",
    "params": {
      "lr": 0.00015
    }
  },
  "fp16": {
    "enabled": true
  },
  "zero_optimization": true
}

Add boolean zero_optimization support by referring to https://github.com/microsoft/DeepSpeed/blob/0c6c98110947300636937d45d6b3392c84996130/deepspeed/runtime/zero/config.py#L54-L72

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@muellerzr

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not have us support deprecated things that they are actively getting rid of

@muellerzr muellerzr closed this Dec 6, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ZhangShuaiyi
Copy link
Author

@muellerzr thanks for your review!
How about implementing a value check for HfDeepSpeedConfig. within its __init__ method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants