Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] remove require_non_xpu test markers #3301

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Dec 18, 2024

What does this PR do?

Both test cases work on XPU now. Below are the rest results:

===================================================================== PASSES ======================================================================
============================================================= short test summary info =============================================================
PASSED tests/test_optimizer.py::OptimizerTester::test_accelerated_optimizer_step_was_skipped
========================================================== PASSES ===========================================================
================================================== short test summary info ==================================================
PASSED tests/test_kwargs_handlers.py::KwargsHandlerTester::test_grad_scaler_kwargs
======================================== 1 passed, 6 deselected, 1 warning in 3.79s =========================================

@faaany
Copy link
Contributor Author

faaany commented Dec 18, 2024

@muellerzr @yao-matrix

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@faaany
Copy link
Contributor Author

faaany commented Jan 14, 2025

Hi @muellerzr , can we proceed with this PR as well? Thx a lot!

@faaany
Copy link
Contributor Author

faaany commented Jan 21, 2025

Hi @muellerzr @SunMarc , pls don't forget this PR. 😊

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SunMarc SunMarc merged commit 4c2c89e into huggingface:main Jan 22, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants