Fix is_jsonable if integer key in dict (#2857)

huggingface · Feb 13, 2025 · 166f174 · 166f174
1 parent 0c1e566
commit 166f174
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/huggingface_hub/utils/_typing.py b/src/huggingface_hub/utils/_typing.py
@@ -50,7 +50,7 @@ def is_jsonable(obj: Any) -> bool:
         if isinstance(obj, (list, tuple)):
             return all(is_jsonable(item) for item in obj)
         if isinstance(obj, dict):
-            return all(isinstance(key, str) and is_jsonable(value) for key, value in obj.items())
+            return all(isinstance(key, _JSON_SERIALIZABLE_TYPES) and is_jsonable(value) for key, value in obj.items())
         if hasattr(obj, "__json__"):
             return True
         return False

diff --git a/tests/test_utils_typing.py b/tests/test_utils_typing.py
@@ -32,6 +32,7 @@ class CustomType:
         [(1, 2.0, "string"), True],
         {},
         {"name": "Alice", "age": 30},
+        {0: "LABEL_0", 1.0: "LABEL_1"},
     ],
 )
 def test_is_jsonable_success(data):