Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix math extraction #503

Merged
merged 13 commits into from
Jan 18, 2025
Merged

Fix math extraction #503

merged 13 commits into from
Jan 18, 2025

Conversation

hynky1999
Copy link
Collaborator

Fix for extraction of expression.

  • Before it wouldn't extract "10+111 so it's $121". Now it's fixed.
  • Fixed the incorrect import in test.

hynky1999 and others added 13 commits January 11, 2025 18:48
@hynky1999
extract matching
eeaceaf
@hynky1999
better docstring
4f1f85a
@hynky1999
lazy imports
bc45376
@hynky1999
bump up math
c24870e
@hynky1999 @clefourrier
Update src/lighteval/metrics/dynamic_metrics.py
2086fe7 
Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
@hynky1999
fix pr commnets
88b9f8c
@hynky1999
Merge branch 'math_extraction' of github.com:huggingface/lighteval in…
ebd695c 
…to math_extraction
@hynky1999 @clefourrier
Apply suggestions from code review
a02bb15 
Co-authored-by: Clémentine Fourrier <22726840+clefourrier@users.noreply.github.com>
@hynky1999
Merge branch 'math_extraction' of github.com:huggingface/lighteval in…
5aa6789 
…to math_extraction
@hynky1999
rename comparisson -> comparison
bb19ebb
@hynky1999
fix expr numbers extraction with currency or units
beb31ea
@hynky1999
Merge remote-tracking branch 'origin/main' into math_extraction
7f6afce
@hynky1999
add test for correct extraction of failed answer
b620bf5
@clefourrier clefourrier merged commit 90d44c1 into main Jan 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clefourrier clefourrier clefourrier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hynky1999 @clefourrier