-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test configurations for quantization with onnxruntime, awq, bnb (#95) #144
add test configurations for quantization with onnxruntime, awq, bnb (#95) #144
Conversation
aliabdelkader
commented
Mar 4, 2024
- add test configurations for onnxruntime backend
- add no_weights sweep to quantization tests
- add test configuration for pytorch awq quantization
- add test configuration for bnb quantization
- add autoawq and bitsandbytes libraries to optional install requirements
- update makefile and github workflow so that the autoawq & bnb get installed and their related tests run successfully locally and on CI
- add test configurations for onnxruntime backend - add no_weights sweep to quantization tests - add test configuration for pytorch awq quantization - add test configuration for bnb quantization - add autoawq and bitsandbytes libraries to optional install requirements - update makefile and github workflow so that the autoawq & bnb get installed and their related tests run successfully locally and on CI
Thank you in advance. |
thanks a lot for the PR
|
- remove autoawq bitsandbytes from setupy.py - add autoawq bitsandbytes to github workflows and makefie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you very much! very nice test configurations, that's exactly what I had in mind 😊
I left some comments
awesome ! all |
Thank you very much for your quick responses and support. I made a new commit addressing the review comments that you had. I just want to raise again the point about installation of autoawq and bitsandBytes (point 3 from earlier). I have removed them from the setup.py as we discussed. But, to be honest, I think the setup.py approach is more maintainable on the long run. As, it puts all the installation requirements in one place which will make it easier for users/developers to look for it in the future. Also, pinning the dependencies to a specific version would be easier if it is done in one place. I will leave the decision up to you. if you would like me to revert back and add them again to the setup.py, please me know. Otherwise, in case you do not any further comments, I think this PR can be merged assuming it passes on the CI. Thank you in advance. |
thank you @aliabdelkader ! Yes feel free to add them but we will have to remove them at some point because |
- update github workflow files to install autoawq and bnb using setup.py - "requests" is installed independently because "autoawq@git+https..." requires it to proceed with its installation.
@aliabdelkader all that is left is styling |
yes, sorry I forgot to run the Linter earlier. |