Fixing clippy issues present in upgraded rust version (#155)

Fixes new clippy issues noted by rust nightly 01-27-25.

cas_types/src/key.rs

@@ -63,7 +63,7 @@ pub mod hex {
         // Visitor for deserialization
         struct HexVisitor;
 
-        impl<'de> Visitor<'de> for HexVisitor {
+        impl Visitor<'_> for HexVisitor {
             type Value = MerkleHash;
 
             fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {

mdb_shard/src/shard_file_manager.rs

@@ -46,7 +46,7 @@ lazy_static! {
 }
 
 // The structure used as the target for the dedup lookup
-#[repr(packed)]
+#[repr(Rust, packed)]
 struct ChunkCacheElement {
     cas_start_index: u32, // the index of the first chunk
     cas_chunk_offset: u16,
@@ -417,9 +417,9 @@ impl ShardFileManager {
         Ok(())
     }
 
-    async fn flush_internal<'a>(
+    async fn flush_internal(
         &self,
-        mem_shard: &mut tokio::sync::RwLockWriteGuard<'a, MDBShardFlushGuard>,
+        mem_shard: &mut tokio::sync::RwLockWriteGuard<'_, MDBShardFlushGuard>,
     ) -> Result<Option<PathBuf>> {
         Ok(if let Some(path) = mem_shard.flush()? {
             self.load_and_cleanup_shards_by_path(&[&path]).await?;

mdb_shard/src/shard_in_memory.rs

@@ -143,10 +143,7 @@ impl MDBInMemoryShard {
             return None;
         }
 
-        let (chunk_ref, chunk_index_start) = match self.chunk_hash_lookup.get(&query_hashes[0]) {
-            Some(s) => s,
-            None => return None,
-        };
+        let (chunk_ref, chunk_index_start) = self.chunk_hash_lookup.get(&query_hashes[0])?;
 
         let chunk_index_start = *chunk_index_start as usize;
 

merkledb/src/async_chunk_iterator.rs

@@ -203,8 +203,8 @@ where
 
 struct HasherPointerBox<'a>(*mut gearhash::Hasher<'a>);
 
-unsafe impl<'a> Send for HasherPointerBox<'a> {}
-unsafe impl<'a> Sync for HasherPointerBox<'a> {}
+unsafe impl Send for HasherPointerBox<'_> {}
+unsafe impl Sync for HasherPointerBox<'_> {}
 
 /// low Variance Chunk Generator given an input stream. Do not use directly.
 /// Use `async_chunk_target_default` or `async_low_variance_chunk_target`.

merkledb/src/chunk_iterator.rs

@@ -29,7 +29,7 @@ fn fill_buf(reader: &mut impl Read, buf: &mut [u8]) -> io::Result<usize> {
     reader.read(buf)
 }
 
-impl<'a, T: Read> Chunker<'a, T> {
+impl<T: Read> Chunker<'_, T> {
     fn gen(&mut self) -> Vec<Chunk> {
         let mut ret: Vec<Chunk> = Vec::with_capacity(1024);
         let mut chunkbuf: Vec<u8> = Vec::with_capacity(self.maximum_chunk);
@@ -136,7 +136,7 @@ pub struct LowVarianceChunker<'a, T: Read> {
     mask: u64,
 }
 
-impl<'a, T: Read> LowVarianceChunker<'a, T> {
+impl<T: Read> LowVarianceChunker<'_, T> {
     fn gen(&mut self) -> Vec<Chunk> {
         let mut ret: Vec<Chunk> = Vec::with_capacity(1024);
         let mut chunkbuf: Vec<u8> = Vec::with_capacity(self.maximum_chunk);

merkledb/src/merkledbbase.rs

@@ -1,6 +1,3 @@
-use super::error::*;
-use super::merklenode::*;
-
 /**
 Basic Concepts
 ==============
@@ -70,6 +67,8 @@ Root: This are nodes in the MerkleDAG with no parent.
 
 File Root: This are nodes in the MerkleDAG which correspond to actual user files.
 */
+use super::error::*;
+use super::merklenode::*;
 
 /**
  * This defines the basic minimal database interface for a MerkleDB.

utils/src/async_read.rs

@@ -13,15 +13,15 @@ pub struct CopyReader<'r, 'w, R, W> {
     writer: &'w mut W,
 }
 
-impl<'r, 'w, R: AsyncRead + Unpin, W: Write> AsyncRead for CopyReader<'r, 'w, R, W> {
+impl<R: AsyncRead + Unpin, W: Write> AsyncRead for CopyReader<'_, '_, R, W> {
     fn poll_read(mut self: Pin<&mut Self>, cx: &mut Context<'_>, buf: &mut [u8]) -> Poll<std::io::Result<usize>> {
         let res = ready!(self.src.as_mut().poll_read(cx, buf))?;
         self.writer.write_all(&buf[..res])?;
         Poll::Ready(Ok(res))
     }
 }
 
-impl<'r, 'w, R: AsyncRead + Unpin, W: Write> Unpin for CopyReader<'r, 'w, R, W> {}
+impl<R: AsyncRead + Unpin, W: Write> Unpin for CopyReader<'_, '_, R, W> {}
 
 impl<'r, 'w, R: AsyncRead + Unpin, W: Write> CopyReader<'r, 'w, R, W> {
     pub fn new(src: &'r mut R, writer: &'w mut W) -> Self {