Simplify shard manager #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile-manager-simplified
hoytak
commented
Jan 29, 2025
| @@ -110,8 +112,10 @@ impl XorbUpload for ParallelXorbUploader { | |||
| upload_tasks.spawn_on( | |||
| async move { | |||
| let ret = upload_and_register_xorb(item, shard_manager, cas, cas_prefix).await; | |||
| if let Some(updater) = upload_progress_updater { | |||
| updater.update(xorb_data_len as u64); | |||
| if ret.is_ok() { | |||
There was a problem hiding this comment.
This was a minor typo that I found debugging...
hoytak
commented
Jan 29, 2025
| target_shard_min_size: u64, | ||
| chunk_dedup_disabled: bool, | ||
| chunk_dedup_enabled: bool, |
There was a problem hiding this comment.
This is an easier name...
seanses
reviewed
Jan 30, 2025
| @@ -165,7 +169,8 @@ async fn upload_and_register_xorb( | |||
| (*hash, pos as u32) | |||
| }) | |||
| .collect(); | |||
| cas.put(&cas_prefix, &cas_hash, data, chunk_and_boundaries).await?; | |||
| // XXXXXX | |||
seanses
reviewed
Jan 30, 2025
| @@ -185,7 +190,8 @@ async fn upload_and_register_xorb( | |||
| .collect(); | |||
| let cas_info = MDBCASInfo { metadata, chunks }; | |||
|
|
|||
| shard_manager.add_cas_block(cas_info).await?; | |||
| // XXXXXXX | |||
seanses
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies parts of the shard manager and adds some tests; it currently doesn't contain any significant functional changes.