add clean_file_from_url #165
Open
+310
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanses
reviewed
Feb 5, 2025
data/src/data_client.rs
Outdated
| let path = PathBuf::from(path); | ||
| let mut read_buf = vec![0u8; READ_BLOCK_SIZE]; | ||
|
|
||
| let response = reqwest::get(file_url).await?; |
There was a problem hiding this comment.
Our build_http_client can build a client with retry capability.
seanses
reviewed
Feb 5, 2025
| .await?; | ||
|
|
||
| loop { | ||
| let bytes = reader.read(&mut read_buf).await?; |
There was a problem hiding this comment.
But I'm not sure how does the RetryMiddleware works with stream reading. If an error occurs within this read() does the RetryMiddleware retries this read or the entire GET? If it retries the entire GET what does the next successful read return? If it returns bytes from the beginning of the file then that's problematic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a utility function to clean a file given a url to use to "GET" the file, i.e. an S3 presigned url.
The contents are then read incrementally and passed into the cleaner handle to chunk, dedup and upload.
Intended potential use for streaming files to migrate them.