Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap cache reader in BufReader for speed. #166

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Wrap cache reader in BufReader for speed. #166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a5853e
Wrap cache reader in BufReader for speed.
hoytak Feb 5, 2025
b9502ae
Merge remote-tracking branch 'origin/main' into hoytak/250205-bufread…
hoytak Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions chunk_cache/src/disk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,15 +264,17 @@ impl DiskCache {
}
}

let Ok(header) = CacheFileHeader::deserialize(&mut file)
let mut file_reader = std::io::BufReader::new(file);

let Ok(header) = CacheFileHeader::deserialize(&mut file_reader)
.debug_error(format!("failed to deserialize cache file header on path: {path:?}"))
else {
self.remove_item(key, &cache_item)?;
continue;
};

let start = cache_item.range.start;
let result_buf = get_range_from_cache_file(&header, &mut file, range, start)?;
let result_buf = get_range_from_cache_file(&header, &mut file_reader, range, start)?;
return Ok(Some(result_buf));
}
}
Expand Down