Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CasObject + LocalClient #5

Merged
merged 7 commits into from
Sep 12, 2024
Merged

CasObject + LocalClient #5

merged 7 commits into from
Sep 12, 2024

Conversation

rajatarya
Copy link
Collaborator

cas_object crate with cas_client/local_client.rs updated to use cas_object crate.

All unit-tests pass.

Next up is remote_client.rs, but this should bring new CAS Object format into xet-core.

@rajatarya
Copy link
Collaborator Author

Most of this code has been reviewed in the xetpoc-monorepo but has been adapted so it can fit into this repo (crates moved around, creating CasObjectError).

Happy to walk through this code since the changes all appear new. Just let me know.

Relevant PRs:

@rajatarya
Copy link
Collaborator Author

I recommend looking at local_client.rs - it is the main glue between cas_object_format.rs and the rest of cas_client crate.

Copy link
Collaborator

@seanses seanses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you rebase off the latest main and let the CI run and check?

Cargo.toml Show resolved Hide resolved
@rajatarya rajatarya merged commit 4844be4 into main Sep 12, 2024
1 check passed
@rajatarya rajatarya deleted the rajat/cas-object branch September 12, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants