-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CasObject + LocalClient #5
Conversation
- all unit-tests are running successfully.
Most of this code has been reviewed in the xetpoc-monorepo but has been adapted so it can fit into this repo (crates moved around, creating CasObjectError). Happy to walk through this code since the changes all appear new. Just let me know. Relevant PRs: |
I recommend looking at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you rebase off the latest main and let the CI run and check?
cas_object crate with cas_client/local_client.rs updated to use cas_object crate.
All unit-tests pass.
Next up is remote_client.rs, but this should bring new CAS Object format into xet-core.