Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use humctl wait #2

Merged
merged 1 commit into from
Apr 26, 2024
Merged

feat: use humctl wait #2

merged 1 commit into from
Apr 26, 2024

Conversation

johanneswuerbach
Copy link
Contributor

Use --wait instead of a custom bash loop.

TobiasBabin
TobiasBabin approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@TobiasBabin TobiasBabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

Once the new image is built, we can then also update the instructions in the docs. I'll prepare a PR.

@johanneswuerbach johanneswuerbach merged commit d80dfb1 into main Apr 26, 2024
1 check passed
@johanneswuerbach johanneswuerbach deleted the humctl-wait branch April 26, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiasBabin TobiasBabin TobiasBabin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanneswuerbach @TobiasBabin