Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update demo to use newapp-io drivers #6

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: update demo to use newapp-io drivers #6

merged 1 commit into from
Oct 11, 2024

Conversation

delca85
Copy link
Contributor

@delca85 delca85 commented Oct 11, 2024 •
edited
Loading

This updates the idp image to use the newapp-io drivers. Particularly:

  • dns definition is updated to use the new driver (as tls-cert default definition validates .newapp.io subdomain now)
  • cluster definition is updated to set localhost as loadbalancer
  • 30443 is exposed to handle https cluster

Tested on Mac Os.

Screenshot 2024-10-11 at 14 39 59

TobiasBabin
TobiasBabin approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@TobiasBabin TobiasBabin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on Ubuntu (WSL) on image built from this branch.

[Edit] URL was https://5min-idp-ykcb-egdc.tobmaster.newapp.io:30443/, not shown on screenshot.

Before merging though, I recommend getting another engineering approval.

image

@jayonthenet
Copy link
Contributor

LGTM

@jayonthenet jayonthenet merged commit 8e24f43 into main Oct 11, 2024
1 check passed
@jayonthenet jayonthenet deleted the fix-with-newapp-io branch October 11, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiasBabin TobiasBabin TobiasBabin approved these changes

@astromechza astromechza Awaiting requested review from astromechza

@mathieu-benoit mathieu-benoit Awaiting requested review from mathieu-benoit

@Nilsty Nilsty Awaiting requested review from Nilsty

@chris-stephenson chris-stephenson Awaiting requested review from chris-stephenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delca85 @jayonthenet @TobiasBabin