Merge pull request #240 from humhub/f-43-internal-remove-manifest-suf…

…ix-on-push Remove sufix
humhub · Oct 8, 2024 · fb8b88a · fb8b88a
2 parents 8309023 + ba89c4a
commit fb8b88a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/util/openers/opener_controller.dart b/lib/util/openers/opener_controller.dart
@@ -132,7 +132,7 @@ class OpenerController {
   }
 
   bool get allOk => !(asyncData == null || asyncData!.hasError || !doesViewExist);
-
+  // TODO: Add localization
   String? validateUrl(String? value) {
     if (value == error404) return 'Your HumHub installation does not exist';
     if (value == noConnection) return 'Please check your internet connection.';

diff --git a/lib/util/openers/universal_opener_controller.dart b/lib/util/openers/universal_opener_controller.dart
@@ -6,6 +6,8 @@ import 'package:http/http.dart' as http;
 import '../api_provider.dart';
 import '../connectivity_plugin.dart';
 
+
+// TODO: Rewrite openers so that the opener_controller will expand universal_opener_controller
 class UniversalOpenerController {
   late AsyncValue<Manifest>? asyncData;
   bool doesViewExist = false;
@@ -19,7 +21,7 @@ class UniversalOpenerController {
     String? manifestUrl;
     for (var url in possibleUrls) {
       asyncData = await APIProvider.requestBasic(Manifest.get(url));
-      manifestUrl = url;
+      manifestUrl = Manifest.getUriWithoutExtension(url);
       if (!asyncData!.hasError) break;
     }
     return manifestUrl;