Add CacheControl tests

[Cyberbeni]

Noticed that CacheControl doesn't work with .any, tried adding XCTExpectedFailure for the failing test but apparently it is not implemented on Linux. Don't know when I'll have the time to look into fixing it, so I'm only submitting the tests for now.

[adam-fowler]

I added a fix so you PR passes all its tests

[Cyberbeni]

Removed the func == implementation, since it wasn't working (probably because Category is RawRepresentable and that default implementation of Equatable is higher priority than default implementation for types with only equatable variables) and it also wasn't transitive. https://developer.apple.com/documentation/swift/equatable

Since equality between instances of Equatable types is an equivalence relation, any of your custom types that conform to Equatable must satisfy three conditions, for any values a, b, and c:

• a == a is always true (Reflexivity)
• a == b implies b == a (Symmetry)
• a == b and b == c implies a == c (Transitivity)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (006cb40) to head (8bbc20e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
+ Coverage   83.82%   84.00%   +0.17%     
==========================================
  Files         117      117              
  Lines        7444     7444              
==========================================
+ Hits         6240     6253      +13     
+ Misses       1204     1191      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adam-fowler]

An alternative solution would be to change the == implementation to ~= and remove the Equatable conformance from Category and use the ~= inside isType.

[Cyberbeni]

Ok, I also removed Category.Internal as it was redundant to have the same cases for the wrapper type.

[Cyberbeni]

As far as I know, the only breaking change is that a switch case over Category will produce a warning for the default case if all the cases are listed.

[adam-fowler]

Ok, I also removed Category.Internal as it was redundant to have the same cases for the wrapper type.

Public enums in libraries are not a good idea, because adding cases to them is a breaking change. You need to wrap them in a struct to avoid the breaking change. See this pitch which will hopefully make it into swift https://forums.swift.org/t/pitch-extensible-enums-for-non-resilient-modules/77649

[Cyberbeni]

Ah,this comes up every time I forget about it... It was even mentioned in the original proposal: https://github.com/swiftlang/swift-evolution/blob/main/proposals/0192-non-exhaustive-enums.md#allow-enums-defined-in-source-packages-to-be-considered-non-frozen

[adam-fowler]

Looks good