Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mask CurrentVersion everywhere #32

Merged
merged 3 commits into from
Feb 24, 2024
Merged

feat: Mask CurrentVersion everywhere #32

merged 3 commits into from
Feb 24, 2024

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Feb 23, 2024 •
edited
Loading

Follow-up to #29

Thanks for releasing v2.1.0 so quickly.
I tried it and found that CurrentVersion are not masked in Array.

In this PR, maskCurrentVersionRefs is more generalized

  • to also mask elements in Array
  • to mask keys, not only in template.Resources, but all keys
  • to mask values, not only { "Ref": "..."}, but all values

@exoego exoego marked this pull request as ready for review February 23, 2024 01:36
@exoego exoego changed the title feat: Mask CurrentVersion in Array feat: Mask CurrentVersion in Array and in keys and values of Record Feb 23, 2024
@exoego exoego changed the title feat: Mask CurrentVersion in Array and in keys and values of Record feat: Mask CurrentVersion everywhere Feb 23, 2024
hupe1980
hupe1980 approved these changes Feb 24, 2024
View reviewed changes
Copy link
Owner

@hupe1980 hupe1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx

@hupe1980 hupe1980 merged commit d89ce7e into hupe1980:master Feb 24, 2024
2 checks passed
@exoego exoego deleted the version branch February 24, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hupe1980 hupe1980 hupe1980 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exoego @hupe1980