Skip to content

Commit

Permalink
fix(hydro_deploy): always write logs to stdout
Browse files Browse the repository at this point in the history
Previously, some logs may have gone to stderr depending on the status of the `ProgressBar`. Also enables `rust-lld` linker on Apple Silicon to improve compilation times.
  • Loading branch information
shadaj committed Feb 5, 2025
1 parent 2fc071e commit d0aa1b7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ rustflags = [
'--cfg=HYDROFLOW_GENERATE_DOCS',
]

[target.aarch64-apple-darwin]
linker = "rust-lld"

[target.x86_64-apple-darwin]
linker = "rust-lld"

Expand Down
6 changes: 2 additions & 4 deletions hydro_deploy/core/src/progress.rs
Original file line number Diff line number Diff line change
Expand Up @@ -370,11 +370,9 @@ impl ProgressTracker {
.lock()
.unwrap();

if progress_bar.current_count == 0
|| progress_bar.multi_progress.println(msg.as_ref()).is_err()
{
progress_bar.multi_progress.suspend(|| {
println!("{}", msg.as_ref());
}
});
}

pub fn with_group<'a, T, F: Future<Output = T>>(
Expand Down

0 comments on commit d0aa1b7

Please sign in to comment.