feat(hydroflow_plus)!: introduce an unordered variant of streams to strengthen determinism guarantees #1568
+799
−575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hydroflow with
|
| Latest commit: |
1044f81
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://693726cb.hydroflow.pages.dev |
| Branch Preview URL: | https://pr1568.hydroflow.pages.dev |
shadaj
force-pushed
the
pr1568
branch
3 times, most recently
from
1fab24c to
2600053
Compare
davidchuyaya
requested changes
Nov 17, 2024
shadaj
force-pushed
the
pr1568
branch
2 times, most recently
from
09f71ab to
48b6c01
Compare
…trengthen determinism guarantees Previously, sending data from a `Cluster` would return a stream assumed to have deterministic contents **and** ordering, which is false. This introduces another type parameter for `Stream` which tracks whether element ordering is expected to be deterministic, and restricts operators such as `fold` and `reduce` to commutative aggregations accordingly.
MingweiSamuel
approved these changes
Nov 21, 2024
|
(Didn't look at the paxos code deeply) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, sending data from a
Clusterwould return a stream assumed to have deterministic contents and ordering, which is false. This introduces another type parameter forStreamwhich tracks whether element ordering is expected to be deterministic, and restricts operators such asfoldandreduceto commutative aggregations accordingly.Stack created with Sapling. Best reviewed with ReviewStack.