Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: loop { scheduler #1692

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: loop { scheduler #1692

wants to merge 13 commits into from

Conversation

MingweiSamuel
Copy link
Member

@MingweiSamuel MingweiSamuel commented Jan 30, 2025 •
edited
Loading

Fix #1580

@MingweiSamuel MingweiSamuel mentioned this pull request Feb 1, 2025
Closed
@MingweiSamuel MingweiSamuel changed the title feat: loop block scheduler WIP (2) feat: loop block scheduler Feb 1, 2025
@MingweiSamuel MingweiSamuel marked this pull request as ready for review February 1, 2025 02:03
@MingweiSamuel
Copy link
Member Author

Still needs a bit of cleanup but everything is working

@MingweiSamuel MingweiSamuel mentioned this pull request Feb 3, 2025
Open
12 tasks
jhellerstein
jhellerstein approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@jhellerstein jhellerstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I understand it. Most of my comments are around what I wasn't sure I understood, so maybe some inline comments will be enough to address.

dfir_lang/src/graph/flat_to_partitioned.rs Show resolved Hide resolved
dfir_lang/src/graph/hydroflow_graph.rs Show resolved Hide resolved
dfir_lang/src/graph/hydroflow_graph.rs Show resolved Hide resolved
dfir_lang/src/graph/hydroflow_graph.rs Show resolved Hide resolved
dfir_lang/src/graph/hydroflow_graph.rs Outdated Show resolved Hide resolved
dfir_rs/src/scheduled/graph.rs Outdated Show resolved Hide resolved
dfir_rs/src/scheduled/graph.rs Show resolved Hide resolved
dfir_rs/src/scheduled/graph.rs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally hard to understand/evaluate this code without a design doc!

dfir_rs/src/util/priority_stack.rs Show resolved Hide resolved
dfir_rs/src/util/slot_vec.rs Show resolved Hide resolved
@MingweiSamuel MingweiSamuel changed the title feat: loop block scheduler feat: loop { scheduler Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhellerstein jhellerstein jhellerstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(dfir_rs): Implement flo loop semantics in current scheduler
2 participants
@MingweiSamuel @jhellerstein