feat(stageleft): support crates that have no entrypoints #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5d67faa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca6db8e4.hydroflow.pages.dev |
| Branch Preview URL: | https://pr983.hydroflow.pages.dev |
shadaj
force-pushed
the
pr983
branch
2 times, most recently
from
4c0f7b3 to
6ac38d6
Compare
shadaj
changed the title
shadaj
changed the title
shadaj
changed the title
shadaj
changed the title
shadaj
changed the title
Also includes various bugfixes needed for Hydroflow+.
MingweiSamuel
approved these changes
Dec 19, 2023
Comment on lines
+15
to
+22
| let underscored_ident = syn::Ident::new(&underscored, Span::call_site()); | ||
| quote! { #underscored_ident } | ||
| } else { | ||
| quote! { crate } | ||
| } | ||
| } | ||
| proc_macro_crate::FoundCrate::Name(name) => { | ||
| let ident = syn::Ident::new(&name, Span::call_site()); |
There was a problem hiding this comment.
was there before, but presumably these Span::call_site should get swapped for meaningful spans some day ™️?
There was a problem hiding this comment.
Yeah... basically all the spans involved here are cross-crate spans, so some day ™️ indeed.
nickjiang2378
pushed a commit
to nickjiang2378/hydroflow
that referenced
this pull request
Jan 25, 2024
…ct#983) Also includes various bugfixes needed for Hydroflow+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(stageleft): support crates that have no entrypoints
Also includes various bugfixes needed for Hydroflow+.
Stack created with Sapling. Best reviewed with ReviewStack.