Improve example server and client #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Better debug output: nesting levels are indicated by indentation. * Support debugging arbitrary levels of nested bundles. * Use the higher-level server.ListenAndServe and a Dispatcher instance.
On my subsequent branch that adds TCP, I added a second argument that is the protocol to use. That's why these scripts currently expect 2 arguments. However, on _this_ branch, only the first argument is used, and that first argument is the port. I ended up b0rking this when I extracted this branch from the rest to make PR review easier. This commit fixes it so that the scripts expect the correct number of arguments, which is 1 argument, the port.
|
To test:
|
hypebeast
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these changes in order to test TCP support when I was implementing it for #37.
I was able to isolate this from the rest of #37 and branch it off of master, which simplifies things for review. This can be reviewed and merged separately from the rest of my PRs.