Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add cancel workflow and format .github files #1170

Merged
merged 7 commits into from
Nov 13, 2023

Conversation

syamsudotdev
Copy link
Contributor

@syamsudotdev syamsudotdev commented Nov 10, 2023

Monika Pull Request (PR)

This PR resolves !1169

What feature/issue does this PR add

  1. Cancels workflow .github/workflows/node.js.yml if one of the job fails

How did you implement / how did you fix it

  1. Added workflow cancel action andymckay/cancel-action@0.3 to every job
  2. Removed .github from .prettierignore
  3. Format files in .github directory

How to test

  1. Make one of run commands fail
  2. See workflow get canceled when one of the jobs fail

Screenshot

image

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #1170 (6a1ebac) into main (c8e7b9f) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 6a1ebac differs from pull request most recent head 744eeb9. Consider uploading reports for the commit 744eeb9 to get more accurate results

@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
+ Coverage   61.05%   61.11%   +0.06%     
==========================================
  Files         106      106              
  Lines        3140     3140              
  Branches      536      536              
==========================================
+ Hits         1917     1919       +2     
  Misses       1036     1036              
+ Partials      187      185       -2     

see 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@syamsudotdev syamsudotdev changed the title chore: add cancel workflow and format .github files Chore: Add cancel workflow and format .github files Nov 10, 2023
@syamsudotdev syamsudotdev merged commit 1ce0a68 into hyperjumptech:main Nov 13, 2023
5 checks passed
@syamsudotdev syamsudotdev deleted the chore/workflow-failfast branch November 13, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants