Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Update Probe Data Independently #1203

Conversation

haricnugraha
Copy link
Contributor

@haricnugraha haricnugraha commented Dec 4, 2023

Monika Pull Request (PR)

What feature/issue does this PR add

Update probe data independently. It is an effort to resolves #1163.

How did you implement / how did you fix it

  1. Polling to Symon probe changes endpoint to get probe changes data.
  2. Apply the probe changes based on the changes type.

How to test

  1. Run Monika in Symon mode.
  2. Add, update, delete a probe.

Video

independent-probe.mp4

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (d35dc5e) 63.70% compared to head (ebe669e) 63.70%.

Files Patch % Lines
src/symon/index.ts 69.81% 8 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1203      +/-   ##
==========================================
- Coverage   63.70%   63.70%   -0.01%     
==========================================
  Files         111      111              
  Lines        3237     3270      +33     
  Branches      551      556       +5     
==========================================
+ Hits         2062     2083      +21     
- Misses        998     1002       +4     
- Partials      177      185       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haricnugraha haricnugraha marked this pull request as ready for review December 11, 2023 07:37
Copy link
Contributor

@sapiderman sapiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 looks okl RTM.

@haricnugraha haricnugraha merged commit ea7ca45 into hyperjumptech:main Dec 19, 2023
6 checks passed
@haricnugraha haricnugraha deleted the refactor/1163-update-probe-data-independently branch December 19, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize Probe Update Mechanism
3 participants