Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Snapcraft pipeline #1204

Merged

Conversation

sapiderman
Copy link
Contributor

@sapiderman sapiderman commented Dec 4, 2023

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Fixes issue Release to Snapcraft Failed #1191
  2. Out of date github/action use

How did you implement / how did you fix it

  1. The way snapcraft github/action passes authentication was updated
  2. Now passing token via environment

After PR

      - uses: snapcore/action-publish@v1
        env:
          SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.STORE_LOGIN }}
        with:
          snap: ${{ steps.snapcraft.outputs.snap }}
          release: edge

Before PR

      - uses: snapcore/action-publish@v1
        with:
          store_login: ${{ secrets.STORE_LOGIN }}
          snap: ${{ steps.snapcraft.outputs.snap }}
          release: edge

Reference: snapcraft action docs

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0002a7f) 63.71% compared to head (2f343da) 63.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1204   +/-   ##
=======================================
  Coverage   63.71%   63.71%           
=======================================
  Files         111      111           
  Lines        3211     3211           
  Branches      544      544           
=======================================
  Hits         2046     2046           
  Misses        988      988           
  Partials      177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sapiderman sapiderman merged commit 92d08b8 into hyperjumptech:main Dec 6, 2023
6 checks passed
@sapiderman sapiderman deleted the fix/1191-update-snapcraft-workflow branch December 6, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release to Snapcraft Failed
3 participants