Feat: Remove sendStatus in SymonClient initiate func #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennypradipta
requested review from
nicnocquee,
sapiderman,
raosan,
ilmiawan,
syamsudotdev,
haricnugraha,
lukman7788 and
kevinhermawan
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
==========================================
- Coverage 63.71% 63.70% -0.02%
==========================================
Files 111 111
Lines 3211 3207 -4
Branches 544 544
==========================================
- Hits 2046 2043 -3
- Misses 988 989 +1
+ Partials 177 175 -2 ☔ View full report in Codecov by Sentry. |
sapiderman
approved these changes
Dec 8, 2023
raosan
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monika Pull Request (PR)
What feature/issue does this PR add
This PR fixes #1207
How did you implement / how did you fix it
Remove the sendStatus in initiate() because handshake will send the status automatically
How to test
Run Monika in Symon Mode
Additional Context
Need PR 5931 in Symon