Fix broken snapcraft pipeline #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapiderman
requested review from
ilmiawan,
haricnugraha,
dennypradipta,
kevin-hyperjump,
lukman7788 and
herenacreative
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 63.70% 63.64% -0.07%
==========================================
Files 111 111
Lines 3207 3207
Branches 544 544
==========================================
- Hits 2043 2041 -2
- Misses 989 990 +1
- Partials 175 176 +1 ☔ View full report in Codecov by Sentry. |
haricnugraha
approved these changes
Dec 11, 2023
sapiderman
changed the title
ilmiawan
approved these changes
Dec 15, 2023
sapiderman
added a commit
to sapiderman/monika
that referenced
this pull request
Dec 15, 2023
haricnugraha
pushed a commit
that referenced
this pull request
Dec 18, 2023
* initial fix * add test * add write permission to pipeline (#1209) * fix test expectation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monika Pull Request (PR)
What feature/issue does this PR add
How did you implement / how did you fix it
Testing
success running withc act