Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1313 #1317

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

suyono3484
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Failed to build tarballs #1313

How did you implement / how did you fix it

  1. adding npm run prepack on pack-tarballs scripts in packages.json

How to test

  1. Run the build steps in Publish to Snapcraft workflow locally (npm ci --workspaces --if-present, npm run build --workspaces --if-present, npm ci, npm run pack-tarballs)
  2. No error in build steps
  3. Verify the .tar.gz file is built in the dist directory

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.49%. Comparing base (6a29470) to head (98d37ee).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
+ Coverage   62.51%   63.49%   +0.97%     
==========================================
  Files         112      109       -3     
  Lines        3391     3421      +30     
  Branches      591      584       -7     
==========================================
+ Hits         2120     2172      +52     
+ Misses       1079     1062      -17     
+ Partials      192      187       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sapiderman sapiderman merged commit c384a1e into hyperjumptech:main Aug 15, 2024
10 checks passed
@suyono3484 suyono3484 deleted the 1313-fix-tarballs-build branch September 10, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants