Skip to content

Commit

Permalink
fix: remove gasLimit overrides for rootstock/rootstocktestnet (#247)
Browse files Browse the repository at this point in the history
### Description

fix: remove gasLimit overrides for rootstock/rootstocktestnet

hardcoding the gaslimit this high causes problems in the relayer, as it
will want the IGP payment to cover this limit. if the gas limit is set
to the block gas limit, this is likely never going to happen. so we
remove the overrides.

note, the overrides have been removed in the recently deployed agent
configs. this is to update the default registry metadata to match our
deployed agent setup.

### Backward compatibility

y

### Testing

manual
  • Loading branch information
paulbalaji authored Oct 4, 2024
1 parent 14268ea commit aac55d5
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 10 deletions.
5 changes: 5 additions & 0 deletions .changeset/honest-points-smoke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@hyperlane-xyz/registry': patch
---

Remove gasLimit override for rootstock and roostocktestnet
4 changes: 0 additions & 4 deletions chains/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2826,8 +2826,6 @@ rootstock:
- http: https://rpc.mainnet.rootstock.io/kXhXHf6TnnfW1POvr4UT0YUvujmuju-M
- http: https://public-node.rsk.co
- http: https://mycrypto.rsk.co
transactionOverrides:
gasLimit: 6800000
rootstocktestnet:
blockExplorers:
- apiUrl: https://rootstock-testnet.blockscout.com/api
Expand All @@ -2853,8 +2851,6 @@ rootstocktestnet:
protocol: ethereum
rpcUrls:
- http: https://rpc.testnet.rootstock.io/YZIZHxGCQAryubOWH7LjdtjNkSDb5J-T
transactionOverrides:
gasLimit: 6800000
saakuru:
blockExplorers:
- apiUrl: https://explorer.saakuru.network/api
Expand Down
4 changes: 0 additions & 4 deletions chains/rootstock/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,3 @@ rpcUrls:
- http: https://rpc.mainnet.rootstock.io/kXhXHf6TnnfW1POvr4UT0YUvujmuju-M
- http: https://public-node.rsk.co
- http: https://mycrypto.rsk.co
transactionOverrides:
# Maximum gas the operation can afford. It's an upper limit the user sets to prevent losing gas.
# Reference: https://dev.rootstock.io/concepts/rbtc/gas/
gasLimit: 6800000
2 changes: 0 additions & 2 deletions chains/rootstocktestnet/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,3 @@ rpcUrls:
# Recommended way is to get a new APIKEY whoever wants to run Hyperlane on Rootstock.
# RPC API Dashboard: https://dashboard.rpc.rootstock.io
- http: https://rpc.testnet.rootstock.io/YZIZHxGCQAryubOWH7LjdtjNkSDb5J-T
transactionOverrides:
gasLimit: 6800000

0 comments on commit aac55d5

Please sign in to comment.