Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pluto): Handle write operations inside FlatMap with Future #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pluto): Handle write operations inside FlatMap with Future #187

wants to merge 1 commit into from

Conversation

coveloper
Copy link
Contributor

@coveloper coveloper commented Jan 21, 2025 •
edited
Loading

Description:

Identus example app consistently throws a recursive save error when calling .sendMessage() as described in #183

Wrapping these .flatMap write operations in a Future seems to fix it in my example.
*note: If this is an acceptable fix, we might need to add another similar Future inside addMessages()'s .flatMap

Alternatives Considered (optional):

I had tried adding guard self.hasChanges else { return } on line 12 of NSManagedObjectContext+Save.swift but that didn't seem to have any effect on this issue.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@coveloper coveloper requested a review from a team as a code owner January 21, 2025 08:16
@coveloper coveloper changed the title wrap flatMap write operation in Future fix(pluto): Handle write operations inside FlatMap with Future Jan 21, 2025
@coveloper
Copy link
Contributor Author

Looks like a test failed. Are these tests I can run locally as part of my future PRs? or do they only run on Actions?

@coveloper coveloper force-pushed the jon/fix-cd-recusive-save-2 branch 3 times, most recently from 833b522 to 5e8ad07 Compare February 11, 2025 15:41
@coveloper
wrap flatMap write operation in Future
542062e 
Signed-off-by: Jon Bauer <jon@covelop.org>

ci: update and remove breaking steps

Signed-off-by: goncalo-frade-iohk <goncalo.frade@iohk.io>

update build.yml for xcode16

Signed-off-by: Jon Bauer <jon@covelop.org>

feat(agent): the body on issue credential protocol messages can be null

hyperledger-identus/identus#115
Signed-off-by: goncalo-frade-iohk <goncalo.frade@iohk.io>

commits squashed
@coveloper coveloper force-pushed the jon/fix-cd-recusive-save-2 branch from 5e8ad07 to 542062e Compare February 11, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goncalo-frade-iohk goncalo-frade-iohk goncalo-frade-iohk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coveloper @goncalo-frade-iohk