Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the template doc workflow #1607

Closed
wants to merge 10 commits into from
Closed

Conversation

Veer0x1
Copy link

@Veer0x1 Veer0x1 commented Dec 25, 2024

Proposed changes

Added automated documentation deployment pipeline using GitHub Actions. This workflow automatically builds and deploys documentation when changes are pushed to main branch or when new version tags are created.

Fixes #1593


Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • My Pull Request title is in format < issue name > eg Added links in the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Sorry, something went wrong.

@Veer0x1 Veer0x1 requested a review from a team as a code owner December 25, 2024 08:28
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Veer0x1 Thank you for raising the PR

The issue is to replace this workflow https://github.com/hyperledger/firefly/blob/main/.github/workflows/docs.yml with the template instead of adding a new workflow.

Could you please adjust the PR to do so?

@Veer0x1
Copy link
Author

Veer0x1 commented Jan 24, 2025

@Veer0x1 Thank you for raising the PR

The issue is to replace this workflow https://github.com/hyperledger/firefly/blob/main/.github/workflows/docs.yml with the template instead of adding a new workflow.

Could you please adjust the PR to do so?

done

@EnriqueL8
Copy link
Contributor

EnriqueL8 commented Jan 27, 2025

Thanks @Veer0x1 - Can you make sure to sign your commits for the DCO check? So git commit -s should do the trick

@Veer0x1
Copy link
Author

Veer0x1 commented Jan 28, 2025

Thanks @Veer0x1 - Can you make sure to sign your commits for the DCO check? So git commit -s should do the trick

done

@EnriqueL8
Copy link
Contributor

Sorry @Veer0x1 you need to make sure all your commits in this PR are signed and not just the last one

dodo920306 and others added 9 commits January 29, 2025 21:57
FireFy => FireFly

Signed-off-by: Yu-Lin "Kirin" Chu <dodo920306@gmail.com>
actions/upload-artifact and actions/download-artifact have
been deprecated and need updated.

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Signed-off-by: Ry Jones <ry@linux.com>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Per the LFDT requirements adding an OpenSSF scorecard workflow

Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Veer0x1 <balveer.singhrao.eee21@itbhu.ac.in>
@Veer0x1
Copy link
Author

Veer0x1 commented Jan 29, 2025

I have messed up the commit history on this branch, I will close this PR and create a new clean PR

@Veer0x1 Veer0x1 closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the template doc workflow
4 participants